-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #47
Add tests #47
Conversation
bdc88f6
to
cf0ecbe
Compare
cf0ecbe
to
32531a1
Compare
32531a1
to
9a37cff
Compare
9a37cff
to
263467f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 115 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 2 unresolved discussions (waiting on @KaterynaSloboda)
LayoutFunctions/ClassroomLayout/test/ClassroomLayoutTests.cs
line 47 at r3 (raw file):
} // room with 3 desks
I think this is a room with 9 desks, unless I am reading this code wrong?
Code quote:
// room with 3 desks
LayoutFunctions/LoungeLayout/test/LoungeLayoutTests.cs
line 43 at r3 (raw file):
var boundaryElements = elements.Where(e => offsetedBox.Contains(e.Transform.Origin)).ToList(); foreach (var contentItem in config.ContentItems)
For future people, maybe it is helpful to add comments inside of the tests like, "check that every piece of expected content exists in a room of a matching size"? This is a general comment for the tests in general, a plaintext explanation of what we are looking for.
Code quote:
foreach (var contentItem in config.ContentItems)
263467f
to
ab9b013
Compare
14fa711
to
de9c2f3
Compare
de9c2f3
to
106ab63
Compare
This is a year stale, closing. |
This change is